Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying fractions before solving #1271

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Simplifying fractions before solving #1271

merged 4 commits into from
Sep 14, 2024

Conversation

n0rbed
Copy link
Member

@n0rbed n0rbed commented Sep 13, 2024 •
edited
Loading

@n0rbed n0rbed changed the title Simplifying fractions before solving - issue #1268 Simplifying fractions before solving Sep 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 30.06%. Comparing base (47cfd60) to head (8cb25a8).
Report is 115 commits behind head on master.

Files with missing lines Patch % Lines
src/solver/main.jl 53.84% 6 Missing ⚠️
src/solver/preprocess.jl 75.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1271       +/-   ##
===========================================
+ Coverage    8.30%   30.06%   +21.76%     
===========================================
  Files          46       47        +1     
  Lines        4549     4576       +27     
===========================================
+ Hits          378     1376      +998     
+ Misses       4171     3200      -971

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n0rbed n0rbed merged commit 7043d1d into JuliaSymbolics:master Sep 14, 2024
11 checks passed
@n0rbed n0rbed deleted the rational branch October 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n0rbed @codecov-commenter @ChrisRackauckas